Conversation
The version of ruff linked in the pre-commit was very old, and was missing several issues. This PR updates the checks in the pre-commit config. It also moves `tool.uv.dev-dependencies` to `dependency-groups.dev` since that's the non-deprecated way of doing that.
|
/gemini review |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's development tooling and dependency management. It updates Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully updates ruff and other dependencies, and applies the resulting linting fixes across the codebase. The changes, which are mostly stylistic improvements like import reordering, enhance code quality and consistency. The configuration changes in pyproject.toml are also correct. I found no issues with this pull request.
There was a problem hiding this comment.
Code Review
This pull request successfully updates the ruff linter and pre-commit-hooks to their latest versions, addressing several linting issues across the codebase. The changes include reordering imports for better consistency, adopting the non-deprecated dependency-groups.dev configuration in pyproject.toml, and making minor code style improvements such as using _ for unused variables and more Pythonic conditional assignments. Overall, these changes enhance code quality, maintainability, and ensure the project adheres to updated linting standards. No further issues or improvement opportunities were identified in the changed lines.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 43 43
Lines 4210 4210
=======================================
Hits 3421 3421
Misses 789 789
🚀 New features to boost your workflow:
|
2 participants
The version of ruff linked in the pre-commit was very old, and was
missing several issues.
This PR updates the checks in the pre-commit config. It also moves
tool.uv.dev-dependenciestodependency-groups.devsince that's thenon-deprecated way of doing that.